tests: fix MustNewMember #18584
tests: fix MustNewMember #18584
Conversation
|
Hi @clement2026. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted filessee 21 files with indirect coverage changes @@ Coverage Diff @@
## main #18584 +/- ##
==========================================
+ Coverage 68.73% 68.77% +0.04%
==========================================
Files 420 420
Lines 35474 35474
==========================================
+ Hits 24382 24399 +17
+ Misses 9666 9655 -11
+ Partials 1426 1420 -6 Continue to review full report in Codecov by Sentry.
|
clement2026
force-pushed
the
fix-TestMemberPromote
branch
from
27595a0
to
d846aa1
Compare
Signed-off-by: Clement <gh.2lgqz@aleeas.com>
clement2026
force-pushed
the
fix-TestMemberPromote
branch
from
d846aa1
to
a4d249e
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clement2026, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cc @ahrtr |
Signed-off-by: Clement <gh.2lgqz@aleeas.com>
| m.PeerURLs = urls | ||
| var listeners []net.Listener | ||
| for _, url := range urls { | ||
| l, err := transport.NewListener(url.Host, url.Scheme, nil) |
There was a problem hiding this comment.
The last parameter always nil? What if it's HTTPS communication?
There was a problem hiding this comment.
Added tlsinfo *transport.TLSInfo param to MustNewMember() in case callers need it.
Signed-off-by: Clement <gh.2lgqz@aleeas.com>
The original
MustNewMemberfunction creates a new member without using the specific PeerURLs, causing the leader to fail when sending snapshots to the new member through those PeerURLs.This PR fixes the
MustNewMemberby overriding the new member’s PeerURLs.#18494 depends on this PR
Part of #17098